Bug in EnhancedScoller.ScrollPosition ?

[stefan]

Hey,

I've wanted to scroll a list with one cell in it to a position well within its length. The value was clamped by the follwing line 
(EnhancedScoller.cs:336):


value = Mathf.Clamp(value, 0, GetScrollPositionForCellViewIndex(_cellViewSizeArray.Count - 1, CellViewPositionEnum.Begin));


Seems to me this should be


value = Mathf.Clamp(value, 0, GetScrollPositionForCellViewIndex(_cellViewSizeArray.Count - 1, CellViewPositionEnum.After));


Cheers,
Stefan

[stefan]

And the same again in Line 1984:

_scrollPosition = Mathf.Clamp(_scrollPosition, 0, GetScrollPositionForCellViewIndex(_cellViewSizeArray.Count - 1, CellViewPositionEnum.After));

[echo17]

Thanks for the bug report, you are correct. You will also need to change line 971 for the jump to work without looping. I'll get these updates into the next release.

[stefan]

Pleasure. Good that you found another spot

[firerabbit]

Hmm, after updating to latest version I'm getting an exception from this same line (Mathf.Clamp) on one of my scrollers.

Had to change:


       public T this[int i]
       {
           get { return data[i]; }          
           set { data[i] = value; }
       }
To:

       public T this[int i]
       {
           get
           {
               if( data is null )
               {
                   return default( T );
               }
               else
               {
                   return data[i];
               }
           }

           set { data[i] = value; }
       }
Never had this problem before the update. Everything is working again after I made this change to your code.

My EnhancedScroller that was throwing the exception had only one row in the Prefab that is cloned vertically.  My EnhancedScroller that was working even before the above code update was also a vertical scroller, but had 5 columns. Not sure if that helps?

Great product otherwise, echo17 !

[echo17]

Interesting. Not sure why this is happening, but the code change is definitely worth implementing. I've added it to the newest release. Thanks!

[firerabbit]

Feb 5, 2021 9:13:30 GMT echo17 said:

Interesting. Not sure why this is happening, but the code change is definitely worth implementing. I've added it to the newest release. Thanks!

Thanks for the super fast update, now I'm back on baseline.  Cheers.