Set ScrollPosition on looping scrollers (commented code)

[cxyda]

Hey there, first of all AWESOME script I really like it.

I was just implementing a looping scroller and as it didn't behave like expected I was looking into the code and saw that in the ScrollPosition setter there are some lines of code commented out which then doesn't do anything. I uncommented the code and now everything works as expected. Could you maybe consider to uncomment the code again as well on the next release? Otherwise we could not easily update in the future. The code seems to work without bugs or unwanted behaviour so it seems to be low risk.

I have an additional request of making 2 private methods public. The first one would be SnapJumpComplete(). I'm using JumpToDataIndex in my code as well to jump to a certain index. but when I do so and the tween gets canceled for whatever reason SnapJumpComplete is never called and functionality therefore is broken for future uses. WHen JumpToDataIndex is used within the EnhancedScroller class SnapJumpComplete is passed as the jumpComplete callback but this is not possible when calling it from the outside. So It would be awesome if SnapJumpComplete could be made public as well

The next one is the _Resize() method. I also need to call this one from my script. So please also consider it making it public

Thank you very much! And keep the awesome work going!

Best, Cxyda

P.S. I'm on version 2.33.0

[echo17]

Thanks for the kind words and suggestions.

The commented code in the ScrollPosition setter creates issues when the loop occurs during tweening. Commenting out the code was the only way to fix this, unfortunately. I left the code in there (commented) in case this scenario does not affect your project and you wish to use it. Please see this post for details: link

I'll add changing the public accessibility of the other functions to my list of items to consider.

Thanks!

[cxyda]

Thanks for the lightning fast response !
Hmm okay, i didn't see any weird behavior using that code yet :thinking_face: but thanks for the warning I'll keep an eye open